Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Small tweak to customizing tutorial default style files can be found on github #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented May 31, 2018

PR Summary

Indicate where on GitHub to find the default style files (probably easier than finding them in the local install for most of us). Also lengthened the name of the tutorial to "Customizing Matplotlib with style sheets and rcParams" since it wasn't obvious to me that this explained anything about style files. But maybe too long. .

@jklymak jklymak added this to the v2.2-doc milestone May 31, 2018
@jklymak
Copy link
Member Author

jklymak commented May 31, 2018

I actually think this looks fine, even w/ the long title. The link to the style sheets on GitHub will help me in the future...

https://10100-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/tutorials/index.html#introductory

@@ -12,7 +12,7 @@
:ref:`matplotlib rc <customizing-with-matplotlibrc-files>` file (which is read
at startup to configure matplotlib).

There are a number of pre-defined styles provided by matplotlib. For
There are a number of pre-defined styles `provided by Matplotlib`_. For
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you somehow make clear that these styles are already built in and the link is just for reference. Otherwise, I fear that people will think that they have to download the linked styles and put them somewhere locally.

@NelleV
Copy link
Member

NelleV commented Jun 9, 2018

Thanks @jklymak !

@NelleV NelleV merged commit 33d3fea into matplotlib:master Jun 9, 2018
lumberbot-app bot pushed a commit that referenced this pull request Jun 9, 2018
jklymak added a commit that referenced this pull request Jun 13, 2018
…n-v2.2.2-doc

Backport PR #11355 on branch v2.2.2-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants