-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: make signature background grey #11421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: make signature background grey #11421
Conversation
maybe it's my monitor, but i can't tell a difference in the background colors between those two screen shots. |
@phobson Thanks for pointing that out. The following two images could make this clearer (left is the case from the current online docs, right is the case implemented here). I did not want to make that grey too strong, but I do find that it helps giving some structure for the eye on pages where lots of classes/methods/attributes are documented. |
Thanks for the side-by-side. But still, on my set up, I can't detect a difference between the two backgrounds. The rest of the changes are nice. |
Mhh, the background of the signatures is the only thing I'm changing here. Other differences like links, fontsize etc. have been changed elsewhere in the meantime. Maybe we wait for other people to have a look and see how they view it. |
I think @phobson is angling for a GoFundMe for a new monitor... |
Good news, everyone. I can see the difference on my monitor at home. |
8282f0e
to
68f9da8
Compare
68f9da8
to
1edd593
Compare
PR Summary
This is a follow up on #11411 where the signatures in the documentation did get a slightly larger font size. In addition, to give the docs a clearer structure, one could give the background of the signature lines a slight shade of grey. This allows for a better visual separation between several classes and functions.
Before:
After: