Use null character instead of recasting NULL to char #11485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULL is implementation dependent, so (char)NULL may cause problems. The null character, '\0', is always well defined.
|
Just for reference, with this simple change I am able to build matplotlib succesfully using export CC=clang CXX=clang++
python3 -m venv venv &&
. venv/bin/activate &&
pip install --upgrade pip &&
pip install --upgrade numpy cycler pyparsing python-dateutil pytz six kiwisolver &&
python -mpip install -v . >clang.log 2>&1See |
dopplershift
approved these changes
Jun 22, 2018
dstansby
added a commit
that referenced
this pull request
Jun 23, 2018
…n-v2.2.x Backport PR #11485 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases,
(char)NULLis used instead of'\0'. This pull request is meant to fix that.closes #11484