add __repr__ to GridSpecBase #11492
Merged
add __repr__ to GridSpecBase #11492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jun 23, 2018
|
|
|
@jklymak Since the string is quite short, it's ok to put it in |
jklymak
approved these changes
Jun 25, 2018
anntzer
requested changes
Jun 25, 2018
There was a problem hiding this comment.
Perhaps also include height_ratios and width_ratios in the repr (if not None)? This way eval-ing the repr would actually yield an equivalent GridSpec.
Marking as change request as otherwise eval-ing can yield a different GridSpec, but feel free to dismiss if you really don't want to implement it...
|
@anntzer I was just too lazy 😄 . But you are right, if we make the repr an |
anntzer
approved these changes
Jun 26, 2018
|
anyone can merge after CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
While playing around with gridspecs I found it convenient to have the repr of GridSpec show the number of columns and rows.