Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip 3D rotation example in sphinx gallery #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2018
Merged

Skip 3D rotation example in sphinx gallery #11512

merged 2 commits into from
Jun 29, 2018

Conversation

dstansby
Copy link
Member

This example takes 24 seconds to run, because it does lots of pausing in a loop. I've disabled it in sphinx gallery, to speed up the build by 24 seconds each time!

@anntzer
Copy link
Contributor

anntzer commented Jun 29, 2018

There's also wire3d_animation?

Perhaps leave a comment in the files explaining why they've been sgskipped.

@anntzer
Copy link
Contributor

anntzer commented Jun 29, 2018

Does it actually run faster?
https://circleci.com/gh/dstansby/matplotlib/882?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link gives 9:54 for the docs build step, whereas https://circleci.com/gh/matplotlib/matplotlib/10782?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link (master) gives 9:59.
(No need to overinvestigate it, if it does make things faster for you locally that's good enough.)

@dstansby
Copy link
Member Author

It definitely makes things faster, by construction the example takes ~20 seconds to run because it has a built in number of pauses. I'm guessing the difference in run time is just variation in the other build times, but on average it should come out as 20 seconds faster.

@tacaswell tacaswell merged commit 0aa7a24 into matplotlib:master Jun 29, 2018
@tacaswell tacaswell added this to the v3.0 milestone Jun 29, 2018
@dstansby dstansby deleted the disable-rotate branch June 29, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @anntzer @tacaswell