Small cleanups. #11522
Merged
Small cleanups. #11522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting them out of the backend switching PR. - Removed `matplotlib.sphinxext.plot_directive.sphinx_version` -- it's unused, and less accurate than `sphinx.version_info` (it's limited to major.minor). - Small reorderings in `testing/__init__.py` -- in particular, one comment was misplaced. - In `test_rcparams.py`, move the global setting of `text.usetex` and `lines.linewidth` to the sole test that actually works with them. Note that changes to rcParams are cleared at the end of every test function by an autouse fixture.
timhoffm
approved these changes
Jun 27, 2018
phobson
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting them out of the backend switching PR.
matplotlib.sphinxext.plot_directive.sphinx_version--it's unused, and less accurate than
sphinx.version_info(it'slimited to major.minor).
testing/__init__.py-- in particular, onecomment was misplaced.
test_rcparams.py, move the global setting oftext.usetexandlines.linewidthto the sole test that actually works with them.Note that changes to rcParams are cleared at the end of every test
function by an autouse fixture.
PR Summary
PR Checklist