FIX: Toolbar disappears in TkAgg if window if resized #11559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should solve #6781 When toolbar is "packed" before canvas, it doesn't disappear when the window is resized.
tacaswell
approved these changes
Jul 4, 2018
|
Thanks @816-8055 ! |
|
Why is this the case? Could you add a comment in there explaining that the order of these commands is important and why? |
|
According to this post, widgets are being shrunk in the inverse packing order when space is insufficient inside a Tk window. |
Added reason for change as a comment
dstansby
approved these changes
Jul 4, 2018
|
@meeseeksdev backport to v2.2.x |
jklymak
added a commit
that referenced
this pull request
Jul 8, 2018
…n-v2.2.x Backport PR #11559 on branch v2.2.x
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #6781
When toolbar is "packed" before canvas, it doesn't disappear when the window is resized.