CI: don't run tox to test pytz #11614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We install pandas on 2 of the entries in the test matrix which in pytz. Additionally explicitly install pytz on one of the py3.6 runs.
|
attn @pganssle |
|
This is technically passing, except for 4e8e995 |
|
merged #11613 to get that in. |
jklymak
approved these changes
Jul 10, 2018
QuLogic
approved these changes
Jul 10, 2018
|
Bit late in the game here but this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We install pandas on 2 of the entries in the test matrix which in
pytz. Additionally explicitly install pytz on one of the py3.6 runs.
This is to address the tox run being a bit flaky during pytest collection.
The figure of merit on this PR is that the coverage does not go down at all.