Sort named colors example vertically for easier comparison of similar colors #11658
Conversation
examples/color/named_colors.py
Outdated
|
|
||
| fig, ax = plt.subplots(figsize=(8, 5)) | ||
| fig, ax = plt.subplots(figsize=(12, 10)) |
There was a problem hiding this comment.
Note that no image on the page should be larger than 900 pixels in width (=9 inch @ the default 100dpi). Otherwise the image will overlap (or be downsampled).
Otherwise this is a great idea! 👍
|
This is how the image looks like in the docs:
Did you use rcParams different from the default ones when designing this? |
|
@ImportanceOfBeingErnest Sorry about that, I was plotting in the Jupyter Notebook initially. When I plotted outside the notebook, I noticed the same overlap as in the image you sent. After my latest commit it looks like this for me outside the notebook:
Thanks for the note on the figure size also! |
|
This looks very nice now. 🎉 The error in the |
|
Thanks @joelostblom this was great... |
…omparison of similar colors
|
Thanks for merging! |
…658-on-v2.2.2-doc Backport PR #11658 on branch v2.2.2-doc
PR Summary
Just a suggestion to sort the named colors example vertically in order to place similar colors closer together which can facilitate comparisons. Also changed spacing and the size of the color lines relative the text.
Old appearance
New appearance
PR Checklist
Has Pytest style unit testsNew features are documented, with examples if plot relatedDocumentation is sphinx and numpydoc compliantAdded an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way