DOC: link brokenaxes package in third part #11685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
083feba to
4de192b
Compare
|
Go for it! Happy to help in any way I can!
…On Tue, Jul 17, 2018, 6:27 PM Jody Klymak ***@***.***> wrote:
PR Summary
As pointed out in #11682
<#11682>, there is a
package brokenaxes that could be linked in our thrid-party tools.
@bendichter <https://github.com/bendichter> is it OK to link you package?
Is it in a stable enough state to advertise?
PR Checklist
- Has Pytest style unit tests
- Code is PEP 8 compliant
- New features are documented, with examples if plot related
- Documentation is sphinx and numpydoc compliant
- Added an entry to doc/users/next_whats_new/ if major new feature
(follow instructions in README.rst there)
- Documented in doc/api/api_changes.rst if API changed in a
backward-incompatible way
------------------------------
You can view, comment on, or merge this pull request online at:
#11685
Commit Summary
- DOC: link brokenaxes package in third part
File Changes
- *A* doc/_static/brokenaxes.png
<https://github.com/matplotlib/matplotlib/pull/11685/files#diff-0> (0)
- *M* doc/thirdpartypackages/index.rst
<https://github.com/matplotlib/matplotlib/pull/11685/files#diff-1> (7)
Patch Links:
- https://github.com/matplotlib/matplotlib/pull/11685.patch
- https://github.com/matplotlib/matplotlib/pull/11685.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11685>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAziEtnhjH64ZfC4VlzbsN7kAVP3v0uOks5uHmTBgaJpZM4VTqNj>
.
|
|
I don’t think ci failure is related |
story645
approved these changes
Jul 18, 2018
|
Doc changes are one approval unless controversial for some reason. |
|
Does this get backported? |
|
Don’t see why not. The milestone will backport it. |
|
👍 nifty package. |
|
Yes, I do wonder if it could fit into the core API.... |
jklymak
added a commit
that referenced
this pull request
Jul 18, 2018
…685-on-v2.2.2-doc Backport PR #11685 on branch v2.2.2-doc
|
I just fixed a bug to make sure that the log scales work correctly with brokenaxes (this was in the back of my mind for a while, but linking the package in the third party tools got me excited 😀). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As pointed out in #11682, there is a package
brokenaxesthat could be linked in our thrid-party tools. @bendichter is it OK to link your package? Is it in a stable enough state to advertise?PR Checklist