Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix drawing on qt+retina. #11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2018
Merged

Fix drawing on qt+retina. #11712

merged 1 commit into from
Jul 20, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 20, 2018

PR Summary

@efiring Can you check whether this fixes #11709?

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: Qt labels Jul 20, 2018
@anntzer anntzer added this to the v3.0 milestone Jul 20, 2018
jklymak
jklymak approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue on my retina screen...

efiring
efiring approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works on my system.

@efiring efiring merged commit d23ebc9 into matplotlib:master Jul 20, 2018
@anntzer anntzer deleted the retinaqt branch July 20, 2018 16:26
@jklymak
Copy link
Member

jklymak commented Jul 21, 2018

OK, I still have issues. If I create a window and resize it a bunch of times, I can eventually get a segmentation fault using QT5Agg.

I'm going to guess that is due to this and the previous Qt repaint PR.

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_platform.dylib            0x00007fff510d7f49 _platform_memmove$VARIANT$Haswell + 41
1   libQt5Gui.5.dylib                   0x000000010f6ddbcd QImage::copy(QRect const&) const + 1629
2   libQt5Gui.5.dylib                   0x000000010f6ddec7 QImage::detach() + 103
3   libQt5Gui.5.dylib                   0x000000010f6def6c QImage::setDevicePixelRatio(double) + 44
4   QtGui.so                            0x000000010f3c4ec8 meth_QImage_setDevicePixelRatio(_object*, _object*) + 104
5   python                              0x000000010a05fc68 _PyCFunction_FastCallDict + 200

@jklymak jklymak mentioned this pull request Jul 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: Qt Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Repaint region is wrong on Retina display with Qt5
3 participants
@anntzer @jklymak @efiring