Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary hacks from setup.py. #11722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2018
Merged

Remove unnecessary hacks from setup.py. #11722

merged 1 commit into from
Aug 6, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 21, 2018

  • There are no symlinks in the mpl source tree anymore.
  • MANIFEST was removed from the root directory in 365a0a2 (11 years
    ago).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove unnecessary hacks from setup.py.
1ec9c91 
- There are no symlinks in the mpl source tree anymore.
- MANIFEST was removed from the root directory in 365a0a2 (11 years
  ago).
@WeatherGod
Copy link
Member

Interesting. MANIFEST isn't even made anymore on-the-fly for sdist packages.

efiring
efiring approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dopplershift dopplershift merged commit c433932 into matplotlib:master Aug 6, 2018
@QuLogic QuLogic added this to the v3.0 milestone Aug 6, 2018
@anntzer anntzer deleted the setup.py branch August 6, 2018 20:58
@jdemeyer
Copy link

Is there any chance that this could be backported to 2.2? See #14580.

jdemeyer pushed a commit to jdemeyer/matplotlib that referenced this pull request Jun 20, 2019
@anntzer @jdemeyer
Backport PR matplotlib#11722: Remove unnecessary hacks from setup.py.
540f381 
- There are no symlinks in the mpl source tree anymore.
- MANIFEST was removed from the root directory in 365a0a2 (11 years
  ago).
jdemeyer pushed a commit to jdemeyer/matplotlib that referenced this pull request Jun 20, 2019
@anntzer @jdemeyer
Backport PR matplotlib#11722: Remove unnecessary hacks from setup.py.
4b957fd 
- There are no symlinks in the mpl source tree anymore.
- MANIFEST was removed from the root directory in 365a0a2 (11 years
  ago).
@jdemeyer jdemeyer mentioned this pull request Jun 20, 2019
Merged
6 tasks
@jdemeyer
Copy link

Backport PR at #14582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@anntzer @WeatherGod @jdemeyer @efiring @dopplershift @QuLogic