Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Directly get the size of the renderer buffer from the renderer. #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2018
Merged

Directly get the size of the renderer buffer from the renderer. #11731

merged 1 commit into from
Jul 22, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 21, 2018

... rather than trying to compute it outselves, which can lead to
off-by-one errors due to the use of floats in the initial buffer
request.

Closes #11728.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Directly get the size of the renderer buffer from the renderer.
c624d57 
... rather than trying to compute it outselves, which can lead to
off-by-one errors due to the use of floats in the initial buffer
request.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: Qt labels Jul 21, 2018
@anntzer anntzer added this to the v3.0 milestone Jul 21, 2018
jklymak
jklymak approved these changes Jul 22, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the resize issue I had...

@tacaswell tacaswell merged commit 23420a4 into matplotlib:master Jul 22, 2018
@anntzer anntzer deleted the qt-buffer-off-by-one branch July 22, 2018 00:24
@inxp inxp mentioned this pull request Dec 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: Qt Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Qt5 Segfaults on window resize
3 participants
@anntzer @jklymak @tacaswell