Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small cleanups to backend_agg. #11734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2018
Merged

Small cleanups to backend_agg. #11734

merged 1 commit into from
Aug 4, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 22, 2018

  • The private _get_hinting_flag is unused.
  • Despite what the comment says, draw_markers and draw_path_collection
    can certainly be defined in update_methods (the comment came in at the
    same time as demo_agg_filter.py in b5f348d, which still runs fine
    after this patch).
  • Remove the unused tostring_bgra (which is not publically exposed in
    the wrapper Python-level RendererAgg class -- the C-level class is not
    publically accessible).
  • Small style fixes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Small cleanups to backend_agg.
944c368 
- The private _get_hinting_flag is unused.
- Despite what the comment says, draw_markers and draw_path_collection
  can certainly be defined in update_methods (the comment came in at the
  same time as demo_agg_filter.py in b5f348d, which still runs fine
  after this patch).
- Remove the unused tostring_bgra (which is not publically exposed in
  the wrapper Python-level RendererAgg class -- the C-level class is not
  publically accessible).
- Small style fixes.
@jklymak jklymak added this to the v3.0 milestone Aug 4, 2018
@jklymak jklymak merged commit e010538 into matplotlib:master Aug 4, 2018
@anntzer anntzer deleted the aggcleanup branch August 4, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: agg
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm