-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
update annotations #11801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update annotations #11801
Conversation
This could use a test if at all possible. Not thought about how to do that but one like the one for spines should do it. I’ve marked release critical because it’s a bug just like the one for spines. It would be good to look at connection patches as well or any other artist that uses transforms between axes. I’m 50/50 if we should change the default back for get_tightbbox so that most artists have set_in_layout false instead of true. That would be more backwards compatible. OTOH it is nice to catch some of these transform setting bugs which I think were occasionally an annoyance for some of these more complex artists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but needs a test!
26c44cf
to
4dc049a
Compare
I wrote a image comparison test but it fails on travis. |
Do you have the testing free type installed? |
No I haven't and I don't know how to install it either. The setup script say that I don't have VS 2010 installed even though I have. I don't have the knowledge or time to invest in trying to get the setup script to work on my computer. One string seems to be just about windows7 but I don't believe that I even get that far. |
I think I have the same very issue with installing/compiling the necessary libraries for the image tests. This is windows specific. One thing I haven't tried out yet (because I was always able to find workarounds for the tests) is to use precompiled windows binaries, e.g. the ones provided here. |
4dc049a
to
5dfd52d
Compare
I wrote a different test that don't use image comparision. Lets see if it works. It could probably be even easier by comparing to the default bbox but I am not sure if that is good. |
a61693d
to
b7634a6
Compare
b7634a6
to
50442c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is necessary to make annotations be placed correctly. A before and after picture may help move the review process along...
I believe that it was the same problems with annotations as it was with spine. They are not updated before
get_windows_extent
where called and this maketight_layout
andconstrained_layout
fail.I hope this fix at least some of the issues in #11800.