gridspec tutorial edits #11802
Merged
gridspec tutorial edits #11802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a853e2 to
d695a56
Compare
d695a56 to
5f3449d
Compare
jklymak
approved these changes
Aug 4, 2018
There was a problem hiding this comment.
This is great. My only complaint is numbering all the figures and axes etc. I really think that is less than helpful except to be consistent w/ what was done before. If I were to do a big edit like this, I'd go exactly the opposite direction and remove all these.
tutorials/intermediate/gridspec.py
Outdated
| @@ -235,23 +232,23 @@ | |||
| def squiggle_xy(a, b, c, d, i=np.arange(0.0, 2*np.pi, 0.05)): | |||
| return np.sin(i*a)*np.cos(i*b), np.sin(i*c)*np.cos(i*d) | |||
|
|
|||
|
|
|||
| fig = plt.figure(figsize=(8, 8), constrained_layout=False) | |||
| 10 | |||
|
A nice thing about numbering them all is if you do |
tacaswell
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small edit to the gridspec tutorial.
figurekwarg to thegridspecin figure 2 so that it works with constrained_layout.tight_layoutin figure 6.edit: The plot rendering are fixed with #11801