MAINT Better error message for number of colors versus number of data… #11876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/matplotlib/axes/_axes.py
Outdated
| raise ValueError("color kwarg must have one color per dataset") | ||
| error_message = ( | ||
| "color kwarg must have one color per data sets. %d data " | ||
| "sets and %d colors were provided" % (len(color), nx)) |
There was a problem hiding this comment.
Strictly, it would be "per data set" (singular). And one may finish the sentence with a period. I.e.
"The color kwarg must have one color per data set. %d data "
"sets and %d colors were provided." % (len(color), nx))
But yeah, that message would make it easier to see where things went wrong when calling the function.
ImportanceOfBeingErnest
approved these changes
Aug 17, 2018
timhoffm
approved these changes
Aug 17, 2018
There was a problem hiding this comment.
I agree with @ImportanceOfBeingErnest s comment. Apart from that this is good to go.
jklymak
approved these changes
Aug 18, 2018
|
@meeseeksdev backport to v3.0.x |
lumberbot-app bot
pushed a commit
that referenced
this pull request
Aug 18, 2018
…ersus number of data…
jklymak
added a commit
that referenced
this pull request
Aug 18, 2018
…876-on-v3.0.x Backport PR #11876 on branch v3.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changing slightly the error message when the number of colors don't match the number of datasets. Sometimes it's down deep after several functions, and it is hard to understand it without providing a bit more context.