HTMLWriter, put initialisation of frames in setup #11897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initiation data in the
HTMLWriter
withembed_frames=True
is not set to "zero" when the same writer is used another time. So the following codewould result in an
anim2.html
animation that starts with theanim1
animation.This pr move the initiation from
__init__
tosetup
to avoid that problem.It also set the correct
Nframes
in the embeded case. This doesn't seems to be necessary but it seems better and clearer when the variable is there. The only thing I think it does is to setand
Nframes=0
seems to work . I don't know javascript so I don't know if there are any important difference if the length of the Array is set before it is used or not.I also deleted a variable that is not used anywhere.