Minor fix to ginput_demo. #11926
Merged
Minor fix to ginput_demo. #11926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The sentence in the docstring is both incomplete(?) (at least it ends with a comma...) and adding no information; just remove it. 2) Print slightly more detailed instructions. Could probably be further improved, or just removed, but heh...
jklymak
approved these changes
Aug 24, 2018
|
Merging for now, but agree that it could go away... |
|
Generally, I think that every example needs an explanatory text. While "This provides examples of uses of interactive functions, such as ginput." is not great, it at least gave a bit of context. Just removing the text makes it worse. I'm gonna open a PR to remove the example completely. IMHO it does not illustrate anything reasonable, so it should better go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with a comma...) and adding no information; just remove it.
Could probably be further improved, or just removed, but heh...
PR Summary
PR Checklist