Remove __version__numpy__; simplify dependencies check. #11980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Aug 30, 2018
|
This should get an API change note (just to be safe), but no need for deprecation logic. |
- There isn't really a reason to keep a ton of machinery to propagate `__version__numpy__` as min numpy supported version throughout the repo; we don't do this with other dependencies so I'm sure we can manage manually bumping the numpy version at all places when we want to. - Kill Numpy().check() in setupext. Numpy will always be installed due to its presence in setup_requires -- unless you don't believe in setuptools... - Simplify the version check at import time. If the module isn't present, I think leaving in the ImportError that would have been generated is just fine (note that on recent Pythons it's actually a ModuleNotFoundError which contains *more* information, wrapping it in an ImportError ourselves actually decreases the amount of information available...
|
done |
timhoffm
approved these changes
Aug 31, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__version__numpy__as min numpy supported version throughout therepo; we don't do this with other dependencies so I'm sure we can
manage manually bumping the numpy version at all places when we want
to.
to its presence in setup_requires -- unless you don't believe in
setuptools...
present, I think leaving in the ImportError that would have been
generated is just fine (note that on recent Pythons it's actually a
ModuleNotFoundError which contains more information, wrapping it in
an ImportError ourselves actually decreases the amount of information
available...
PR Summary
PR Checklist