Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor javascript cleanup #11996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2018
Merged

Minor javascript cleanup #11996

merged 1 commit into from
Sep 3, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 2, 2018

PR Summary

  • added a missing space in a text
  • added some semicolons (they would be automatically inserted but all other code uses explicit semicolons, so we stay consistent here)

@timhoffm timhoffm added this to the v3.1 milestone Sep 2, 2018
jklymak
jklymak approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No javascript expert, but looks right to me.

@QuLogic QuLogic merged commit 7c0e760 into matplotlib:master Sep 3, 2018
@timhoffm timhoffm deleted the javascript-cleanup branch September 3, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @jklymak