Remove intent to deprecate rcParams["backend_fallback"]. #12022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa78523 to
405ee75
Compare
tacaswell
approved these changes
Sep 5, 2018
I had left a note intending to deprecate this rcParam back when the backend-switching API would let the user specify an explicit fallback list. As this feature was not accepted, it makes sense to keep the rcparam. Also move its actual use next to the place where the backend is set up in pyplot.py. Also move the call to install_repl_displayhook after that, as install_repl_displayhook calls get_backend() so we want the rcparam to have taken effect already.
405ee75 to
99a2e46
Compare
timhoffm
approved these changes
Sep 5, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 5, 2018
…ckend_fallback"].
anntzer
added a commit
that referenced
this pull request
Sep 7, 2018
…022-on-v3.0.x Backport PR #12022 on branch v3.0.x (Remove intent to deprecate rcParams["backend_fallback"].)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had left a note intending to deprecate this rcParam back when the
backend-switching API would let the user specify an explicit fallback
list. As this feature was not accepted, it makes sense to keep the
rcparam.
Also move its actual use next to the place where the backend is set up
in pyplot.py. Also move the call to install_repl_displayhook after
that, as install_repl_displayhook calls get_backend() so we want the
rcparam to have taken effect already.
PR Summary
PR Checklist