Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix indentation in docstring interpolation for spy. #12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 7, 2018

All's in the title.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@@ -7681,7 +7681,7 @@ def spy(self, Z, precision=0, marker=None, markersize=None,
For the marker style, you can pass any `.Line2D` property except
for *linestyle*:

%(Line2D)s
%(Line2D)s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment/question. Would anyone freak out if I put in a PR that renamed this _Line2D_docstring - its a real PITA trying to find where this is defined by doing a global search.

Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @anntzer !

Verified that the docstring before this change read as

...
     - any `.Artist` properties (passed on to the `.AxesImage`)                                                                                                          [258/1639]
 
     For the marker style, you can pass any `.Line2D` property except
     for *linestyle*:
 
       agg_filter: a filter function, which takes a (m, n, 3) float array and a dpi value, and returns a (m, n, 3) array 
   alpha: float
   animated: bool
   antialiased: bool
   clip_box: `.Bbox`
...

but now that first kwarg is properly indented like so:

...
   For the marker style, you can pass any `.Line2D` property except
     for *linestyle*:
 
   agg_filter: a filter function, which takes a (m, n, 3) float array and a dpi value, and returns a (m, n, 3) array 
   alpha: float
   animated: bool
   antialiased: bool
   clip_box: `.Bbox`
...

@ivanov ivanov merged commit 1393d3b into matplotlib:master Sep 8, 2018
@QuLogic QuLogic added this to the v3.1 milestone Sep 8, 2018
@anntzer anntzer deleted the spyinterpolation branch September 8, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants