Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FAIL: matplotlib.tests.test_text.test_contains.test #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2012
Merged

FAIL: matplotlib.tests.test_text.test_contains.test #1208

merged 1 commit into from
Sep 10, 2012

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Sep 10, 2012 

FAIL: matplotlib.tests.test_text.test_contains.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mdboom/python/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/mdboom/python/lib/python2.7/site-packages/matplotlib/testing/decorators.py", line 39, in failer
    result = f(*args, **kwargs)
  File "/home/mdboom/python/lib/python2.7/site-packages/matplotlib/testing/decorators.py", line 158, in do_test
    '(RMS %(rms).3f)'%err)
ImageComparisonFailure: images not close: /home/mdboom/Work/tmp/matplotlib/tests/result_images/test_text/text_contains.png vs. /home/mdboom/Work/tmp/matplotlib/tests/result_images/test_text/text_contains-expected.png (RMS 122.633)

@leejjoon: ed7db9b introduced a test failure.

It may be that the text alignment in the new output is correct, in which case the baseline images need to be updated.

mdboom added a commit that referenced this pull request Sep 10, 2012
@mdboom
Merge pull request #1208 from mdboom/issue1208
2bd0529 
FAIL: matplotlib.tests.test_text.test_contains.test
@mdboom mdboom merged commit 2bd0529 into matplotlib:master Sep 10, 2012
@leejjoon
Copy link
Contributor

Michael, I just reverted my change (ed7db9b) and pushed it in to the master, without realizing you merging this.
So, I guess the test should fails again. I am sorry for this mass.

The reason I reverted my change is that, after some thought, I was not quite sure if my change is optimal. While I think that the current text position for va=baseline for rotated text need to be fixed, the solution may need some more thought.

So my suggestion is that we release 1.2 w/ these change reverted (both mine and yours) and try to resolve this in the dev. branch. Again, I apologize for this mess.

@mdboom
Copy link
Member Author

mdboom commented Sep 11, 2012

No problem. Thanks for all of your work on this. I'll get this sorted out for the release candidate.

@mdboom mdboom deleted the issue1208 branch March 3, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v1.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @leejjoon