MAINT: Vectorize bar3d #12137
Merged
MAINT: Vectorize bar3d #12137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brought-on to try and determine if faces are clockwise-ordered or counter-clockwise-ordered
dcc48e4 to
5314244
Compare
5314244 to
f44b437
Compare
|
Flake8 failures seem to not be part of this patch? |
|
Style issue is fixed by #12139, feel free to rebase on top of it. |
|
Too lazy to do that. I'll just close and re-open this PR once that one is merged to restart CI |
|
merged #12139 |
|
CI now passes - thanks! |
dstansby
approved these changes
Sep 24, 2018
QuLogic
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors bar3d to use numpy to compute all the coordinates in parallel.
I'm not certain if this actually results in a speed increase, but it does result in a clarity improvement,
This spun out of #12136, which raised the fact that bar3d does not orient its faces correctly (#12138). This patch does not fix that, but it does make it easy to fix in a subsequent revision.
I can split the multiple commits here into multiple PRs if that adds value.