Doc final 3.0 docs #12145
Merged
Doc final 3.0 docs #12145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Sep 17, 2018
Also spelling and markup fixes
pharshalp
reviewed
Sep 18, 2018
doc/users/whats_new.rst
Outdated
| These colormaps start and end on the same color, and have two | ||
| symmetric halves with equal lightness, but diverging color. Since they | ||
| wrap around, they are a good choice for cyclic data such as phase | ||
| angles, compass directions, or time of day. Like *viridis*, *twilight* is |
There was a problem hiding this comment.
Just a small suggestion...
Would it be better to mention cividis instead of viridis as the perceptually uniform and colorblind-friendly colormap? cividis explicitly avoids the green color since red-green is the most common colorblindness.
https://nei.nih.gov/health/color_blindness/facts_about
https://arxiv.org/pdf/1712.01662.pdf
There was a problem hiding this comment.
That is a fair point, but I think viridis is better known at this point.
The red-green issue was considered in the design of {viridis, magma, plasma, inferno} (which is why the first has green but no red and vise versa).
There was a problem hiding this comment.
I'll just put both in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.