-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve docstring of Annotation #12214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docstring of Annotation #12214
Conversation
lib/matplotlib/text.py
Outdated
`~matplotlib.backend_bases.RendererBase` object as input | ||
and return a `~matplotlib.transforms.Transform` or | ||
`~matplotlib.transforms.Bbox` object | ||
where *render* is a `.RendererBase` subclass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renderer
|
97f91ff
to
66d787e
Compare
I've added docstrings for |
See also #12144 re: mismatched names in constructor. |
25ca6ee
to
8bb39f5
Compare
8bb39f5
to
83790a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments handled.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Improve docstring of Annoation
This was tagged with v3.0.x. So when merging, it tried to autobackport to that branch. I resolved the conflict (which was a single empty line (??)), and created #12214, but does this now still need to go to v3.0.0-doc? Should it have been tagged with v3.0.0-doc instead? |
Changes in |
…of-pr-12214-on-v3.0.x Backport PR #12214 on branch v3.0.x
PR Summary
As part of #10148: Docstring update for
Annotation
.