Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Machinery for deprecating properties. #12247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 24, 2018

  • Generate a message saying 'The foo attribute has been deprecated'
    instead of 'The foo function'.
  • Automatically deprecate the setter at the same time as the getter.
  • Also emit the warning when accessing the attribute on the class rather
    than on an instance.

(Compare with the recently removed attempt at supporting deprecation of
classmethods, which didn't really bring anything except the ability to
put the @deprecated decorator over the @classmethod decorator.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- Generate a message saying 'The foo attribute has been deprecated'
  instead of 'The foo function'.
- Automatically deprecate the setter at the same time as the getter.
- Also emit the warning when accessing the attribute on the class rather
  than on an instance.

(Compare with the recently removed attempt at supporting deprecation of
classmethods, which didn't really bring anything except the ability to
put the `@deprecated` decorator over the `@classmethod` decorator.)
@anntzer anntzer force-pushed the property-deprecation branch from fcc8917 to 479c84e Compare September 24, 2018 10:00
@dstansby dstansby added this to the v3.1 milestone Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants