Document inheriting docstrings #12278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Here is a link to the documentation section that's being updated. It's pretty intelligible.
Since this documents a concept that is already used inside the code base, it should be uncontroversial. Hence I would directly merge on the basis of the "This is better than it was"-threshold.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 26, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 26, 2018
timhoffm
pushed a commit
that referenced
this pull request
Sep 26, 2018
timhoffm
pushed a commit
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Document what's defined in #12255.
Note: I've found one instance that already existed before. It uses the more explicit
# docstring inherited from Artist.drawinstead of
# docstring inheritedNot sure it's worth the extra effort.