Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate axis('normal') in favor of axis('auto'). #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

Deprecate axis('normal') in favor of axis('auto'). #12314

merged 1 commit into from
Sep 28, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 27, 2018

This has been deprecated in docstrings since 2006 (d4e54a9, in
set_aspect), even before the axis() was introduced (2e2f850).
Support for set_aspect('normal') has already been removed.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Sep 27, 2018
@ImportanceOfBeingErnest
Copy link
Member

The code and the "api change"-note are contradictory. Which one do you want to deprecate?

@anntzer
Deprecate axis('normal') in favor of axis('auto').
8d9cc12 
This has been deprecated in docstrings since 2006 (d4e54a9, in
`set_aspect`), even before the `axis()` was introduced (2e2f850).
Support for `set_aspect('normal')` has already been removed.
@anntzer
Copy link
Contributor Author

anntzer commented Sep 27, 2018

indeed, fixed :)

@jklymak jklymak merged commit e7b8533 into matplotlib:master Sep 28, 2018
@anntzer anntzer deleted the abnormal branch September 28, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @ImportanceOfBeingErnest @timhoffm @jklymak