-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Log axvline #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log axvline #1247
Conversation
…F and SVG fail to produce suitable results.
@pelson Nice! |
@pelson Which backend are you using for the png? |
Now there is a good question. In the script, I have The pngs are bad when created from the |
|
||
ax.axvline(24.1) | ||
ax.axhline(24.1) | ||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs removing. Its not this that's causing the problem though.
How? The line is in a different place? Or is it bad quality? Can you compare the line created with the
In some sense, that kind of makes sense. Doesn't the testing framework nuke all your |
Completely. |
Bugger. |
:-) indeed. Ok. So I'm going to take stock, and have a good think about this one. The order of saving the results is important, so I think there is some caching issues going on. I'm happy to spend some time on this in the next couple of days to track this down. |
…the affine/non-affine transformation of a BlendedGenericTransform.
This issue should now be completely resolved by this PR. The only remaining concern is getting the text in the image to pass on travis. I will add a new commit which removes the text from the images. |
Fixes the exception in from #1246 of:
The fix was simple enough (added the has_inverse property to the Log transforms). The generated png for the tests looks perfect, unfortunately the PDF and SVGs are not. Strangely, when I run this from a script rather than from the tests, the PDF and SVGs are perfect, but the png produces a line in the wrong place. If anyone has any ideas what may be going on there, it would be greatly appreciated.
As it is, this is a bona fide bug fix, but there still exists some weirdness to investigate.