Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn if plot_surface Z values contain NaN #12481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2018
Merged

Warn if plot_surface Z values contain NaN #12481

merged 1 commit into from
Nov 2, 2018

Conversation

timhoffm
Copy link
Member

PR Summary

In response to #12395

jklymak
jklymak reviewed Oct 10, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first half of the warning makes it sound like it won't work at all, whereas the second half is more correct. Suggest just saying: "Z has NaN values, and may have rendering artifacts".

@timhoffm timhoffm force-pushed the plot_surface-warn-nan branch from 3bedef1 to 2d91d7d Compare October 10, 2018 21:52
@timhoffm timhoffm added this to the v3.1 milestone Oct 13, 2018
@anntzer anntzer merged commit e704fe9 into matplotlib:master Nov 2, 2018
@timhoffm timhoffm deleted the plot_surface-warn-nan branch November 2, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@timhoffm @anntzer @jklymak @dstansby @QuLogic