Kill FontManager.update_fonts. #12483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been listed as a TODO since the first ever commit in the git log (e34a333), has always raised NotImplementedError, and nowadays the suggested action is always to just fully regenerate the font cache anyways.
QuLogic
approved these changes
Oct 10, 2018
jklymak
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been listed as a TODO since the first ever commit in the git log
(e34a333), has always raised NotImplementedError, and nowadays the
suggested action is always to just fully regenerate the font cache
anyways.
PR Summary
PR Checklist