Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update docs/tests for the deprecation of aname and label1On/label2On/etc. #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2018
Merged

Update docs/tests for the deprecation of aname and label1On/label2On/etc. #12487

merged 1 commit into from
Oct 20, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 11, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Oct 11, 2018
@timhoffm
Copy link
Member

Hm, strictly we shouldn't remove aname from the docs yet. It's just deprecated. OTOH, it does not have a real value in the docs.

@anntzer
Copy link
Contributor Author

anntzer commented Oct 11, 2018

It also triggers a bunch of warnings in the doc build... (that's how I noticed it)

@NelleV
Copy link
Member

NelleV commented Oct 20, 2018

This looks good to me! Thanks @anntzer !

@NelleV NelleV merged commit f2c2890 into matplotlib:master Oct 20, 2018
@anntzer anntzer deleted the update-docs branch October 20, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @NelleV @dstansby