Fix scatter() with empty data and c argument #12672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also use |
tacaswell
reviewed
Oct 29, 2018
| @@ -1741,6 +1741,11 @@ def test_scatter_color(self): | |||
| with pytest.raises(ValueError): | |||
| plt.scatter([1, 2, 3], [1, 2, 3], color=[1, 2, 3]) | |||
|
|
|||
| def test_scatter_empty(self): | |||
There was a problem hiding this comment.
Can you also add a test for pandas with a non-0 based index?
|
There is also #12673 with the same aim to fix this. |
|
I'm going to close this @TimHoffman, in favour of #12673, because the proposer for that PR put a lot of effort into getting consensus before opening their PR. Hope that's OK.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #12641. The issue is that
c[0]is accessed for an empty array (the 3d code drops invalid points and thus passes an empty array in case of the MWE #12641 (comment)).Note: While the canonical way of checking emptiness is
if c, I feel it's more clear to uselen(c) > 0here.PR Checklist