Correctly remove nans when drawing paths with pycairo. #12709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare output of `plot([0, nan, 1], "o-")` before and after.
timhoffm
approved these changes
Nov 1, 2018
jklymak
approved these changes
Nov 1, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 2, 2018
…s with pycairo.
dstansby
added a commit
that referenced
this pull request
Nov 2, 2018
…709-on-v3.0.x Backport PR #12709 on branch v3.0.x (Correctly remove nans when drawing paths with pycairo.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare output of
plot([0, nan, 1], "o-")before and after.Before
After
Noted while investigating #12701 (which is completely unrelated, in fact...).
PR Summary
PR Checklist