Warn on FreeType missing glyphs. #12759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Nov 6, 2018
7d9efe3 to
2c247dc
Compare
QuLogic
reviewed
Nov 6, 2018
2c247dc to
db5f2c2
Compare
timhoffm
approved these changes
Nov 9, 2018
db5f2c2 to
cc744f5
Compare
QuLogic
approved these changes
Nov 16, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Redo of #9175, which was partially reverted in #11615, but with an additional warnings filter to fix the warnings spamming that led to the reversion.
See #12597 (and #8765) for cases where the warning helps (feel free to push a better wording for the warning, e.g. point people to set the correct font).
PR Checklist