Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplifications to quiver3d. #12796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Simplifications to quiver3d. #12796

merged 1 commit into from
Nov 12, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 12, 2018

  • No need to convert input_args to lists: broadcast_arrays will handle
    the broadcasting just fine on scalars, and later using np.ravel() will
    ensure that the result is at least 1D.
  • The assertions don't really add much (and are clearly always true
    based on the code just above).
  • np.linspace(x, y, 2) is a pretty obfuscated way to write np.array([x,
    y]).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- No need to convert input_args to lists: broadcast_arrays will handle
  the broadcasting just fine on scalars, and later using np.ravel() will
  ensure that the result is at least 1D.
- The assertions don't really add much (and are clearly always true
  based on the code just above).
- np.linspace(x, y, 2) is a pretty obfuscated way to write np.array([x,
  y]).
@QuLogic QuLogic merged commit 63fe909 into matplotlib:master Nov 12, 2018
@anntzer anntzer deleted the quiver3d branch November 12, 2018 21:59
@QuLogic QuLogic added this to the v3.1.0 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants