Remove unused variables #12829
Merged
Remove unused variables #12829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Nov 18, 2018
| @@ -822,7 +822,7 @@ def __setitem__(self, key, val): | |||
| "either import that binding first, or set the QT_API " | |||
| "environment variable.") | |||
| cbook.warn_deprecated( | |||
| "2.2", name=key, obj_type="rcparam", addendum=addendum) | |||
| version, name=key, obj_type="rcparam", addendum=addendum) | |||
There was a problem hiding this comment.
Replaced the hard-coded value.
timhoffm
commented
Nov 18, 2018
| else: | ||
| verticesA, codesA = [], [] | ||
| ddxA, ddyA = 0., 0. | ||
| verticesA, codesA, ddxA, ddyA = ( |
There was a problem hiding this comment.
IMHO this way it's more clear that the whole block is just a conditional assignment of the four variables.
7832977 to
fa4992b
Compare
anntzer
reviewed
Nov 18, 2018
lib/matplotlib/patches.py
Outdated
| else: | ||
| verticesB, codesB = [], [] | ||
| ddxB, ddyB = 0., 0. | ||
| has_end_arrow = self.endarrow and not (x2 == x3 and y2 == y3) |
There was a problem hiding this comment.
self.endarrow and (x2 != x3 or y2 != y3)
or
self.endarrow and (x2, y2) != (x3, y3)
fa4992b to
94ea287
Compare
jklymak
approved these changes
Nov 19, 2018
|
ping @anntzer for a re-review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary