Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't fail tests if cairo dependency is not installed. #12835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2018
Merged

Don't fail tests if cairo dependency is not installed. #12835

merged 2 commits into from
Nov 20, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 19, 2018

PR Summary

Necessary for the test introduced by #12774.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0.3 milestone Nov 19, 2018
@anntzer anntzer mentioned this pull request Nov 19, 2018
Merged
6 tasks
timhoffm
timhoffm reviewed Nov 19, 2018
View reviewed changes
timhoffm
timhoffm approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semi-official approval because I have code in the PR.

@anntzer
Copy link
Contributor Author

anntzer commented Nov 20, 2018

I approve your commit. Sounds good? :)

@timhoffm timhoffm merged commit e0c9185 into matplotlib:master Nov 20, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 20, 2018
@anntzer
Backport PR matplotlib#12835: Don't fail tests if cairo dependency is…
0267a99 
… not installed.
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 20, 2018
Merged
@anntzer anntzer deleted the skipbackend branch November 20, 2018 21:05
timhoffm pushed a commit that referenced this pull request Nov 27, 2018
@meeseeksmachine @timhoffm
Backport PR #12835: Don't fail tests if cairo dependency is not insta…
146883b 
…lled. (#12854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @jklymak @timhoffm