Keep Collections and Patches property aliases in sync. #12851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know there's some desire to completely get rid of the shorthand aliases, but until this happens, it seems better to have the same aliases available for all classes when that makes sense (and this won't make the deprecation period, if it happens, any harder).
jklymak
approved these changes
Nov 20, 2018
timhoffm
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there's some desire to completely get rid of the shorthand
aliases, but until this happens, it seems better to have the same
aliases available for all classes when that makes sense (and this won't
make the deprecation period, if it happens, any harder).
PR Summary
PR Checklist