Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't use deprecated wx.NewId(). #12861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2018
Merged

Don't use deprecated wx.NewId(). #12861

merged 1 commit into from
Dec 1, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 21, 2018

There are some uses left in MenuButton but that class also needs to be
deprecated anyways (#10209).

Closes #12859.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Don't use deprecated wx.NewId().
8882f3c 
There are some uses left in MenuButton but that class also needs to be
deprecated anyways.
@timhoffm
Copy link
Member

If MenuButton is only deprecated, it may be reasonable to also replace the usages of NewId there to remove the deprecation warnings from the tests.

@anntzer
Copy link
Contributor Author

anntzer commented Nov 22, 2018

It's not tested either, so heh.

@timhoffm
Copy link
Member

😏

DietmarSchwertberger
DietmarSchwertberger approved these changes Dec 1, 2018
View reviewed changes
Copy link
Contributor

@DietmarSchwertberger DietmarSchwertberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DietmarSchwertberger DietmarSchwertberger merged commit 898fbaa into matplotlib:master Dec 1, 2018
@QuLogic QuLogic added this to the v3.1 milestone Dec 2, 2018
@anntzer anntzer deleted the wxnewid branch December 2, 2018 09:39
@tacaswell tacaswell mentioned this pull request May 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@DietmarSchwertberger DietmarSchwertberger DietmarSchwertberger approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: NewId() is deprecated in wxPython.
4 participants
@anntzer @timhoffm @DietmarSchwertberger @QuLogic