Autoscaling and limits in mplot3d.#1289
Conversation
* Fixes improper setting of x,y,z limits not turning off autoscaling
* Adds units support to z-axis
* Adds shared axis support for z-axis
* Closes matplotlib#783
There was a problem hiding this comment.
If z-axis sharing is supported, why not just remove these three lines?
There was a problem hiding this comment.
Whoops, I thought I got all the cruft. I will take care of that.
|
Axes3D can't do twinx/y yet because of the way the axis and axis ticks and labels are drawn. Support for that will have to come much further down the road. |
|
Sweet. Cheers for clarification. |
|
My biggest concern with mplot3d in general is that I don't think there are any tests? At the very least, would you be willing to add a simple test case for this change? |
|
Oh, I whole-heartedly agree that one of mplot3d's main problems is the lack of tests. I have been putting off making such tests because I have never been satisfied with the appearance of the figures. What I do whenever I make an invasive change like this is that I run all of the mplot3d examples (plus others I have) and make sure that they still produce expected results. My one remaining hurdle I have before I am really willing to sit down and create baseline images is getting the 3d axes to take up a significantly larger portion of the subaxes. Right now, everything looks crammed. That should be the last major visual change for mplot3d toolkit. Unfortunately, it is not quite possible to do this, although some changes that have happened over the summer should get us most of the way there. |
|
Now that v1.2.0 is out, I want to merge this bugfix into the maintenance branch and master. Objections? |
|
My feeling is that this should be merged, but just into master. It's not entirely a bugfix, it adds support for things that weren't previously supported. |
|
On Tue, Nov 13, 2012 at 10:23 AM, Damon McDougall
It is a bugfix in the sense that there is a specific bug being fixed. It |
|
@WeatherGod Alright. I'd like to play with it first though. I haven't done that yet. |
|
@WeatherGod Tried this out -- it seems to behave like the 2D case for the example in #783. I haven't tried the units support. How does everyone else feel about this going into the |
There was a problem hiding this comment.
Is there any reason you didn't make this a """ docstring?
There was a problem hiding this comment.
Most of the PEP8 violations here are a result of my copying and pasting from axes.py. Thanks for catching these and I will fix them all (as well as do PEP8 work for mplot3d in a separate PR).
Due to time constraints in releasing v1.2.0, I would understand if this doesn't make it in for the release.