Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Restrict postscript title to ascii. #12890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 26, 2018

The postscript standard makes no reference to the interpretation of
non-ascii entities, so assuming an encoding is incorrect.

See discussion starting at #11130 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The postscript standard makes no reference to the interpretation of
non-ascii entities, so assuming an encoding is incorrect.
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though I have no basis for judging if this is indeed a proper interpretation of the standard....

@timhoffm timhoffm merged commit 18a8a94 into matplotlib:master Nov 26, 2018
@anntzer anntzer deleted the postscript-ascii-title branch November 26, 2018 21:23
@QuLogic QuLogic added this to the v3.0.3 milestone Nov 26, 2018
@QuLogic
Copy link
Member

QuLogic commented Nov 26, 2018

@meeseeksdev backport to v3.0.x

(in line with #12869)

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 26, 2018
dstansby added a commit that referenced this pull request Nov 27, 2018
…890-on-v3.0.x

Backport PR #12890 on branch v3.0.x (Restrict postscript title to ascii.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants