Update docstring of Axes3d.scatter #12949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you got part of #12943 mixed in. |
7c58077 to
d74597b
Compare
|
Woops, fixed. |
dstansby
approved these changes
Dec 15, 2018
WeatherGod
previously requested changes
Dec 17, 2018
lib/mpl_toolkits/mplot3d/axes3d.py
Outdated
| ''' | ||
| Returns | ||
| ------- | ||
| paths : `~mpl_toolkits.mplot3d.art3d.Patch3DCollection` |
There was a problem hiding this comment.
It still says Patch3DCollection. Technically, it is the 3D version of whatever the 2d scatter method returns, which I believe is a PathCollection.
d74597b to
6a3807d
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 22, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 22, 2018
timhoffm
pushed a commit
that referenced
this pull request
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Makes the docstring numpydoc compliant. Also closes #12920 (documentation contained incorrect information on return type).