Cleanup GTK examples. #12984
Merged
Cleanup GTK examples. #12984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now they emit warnings: ``` gtk_spreadsheet_sgskip.py:36: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "homogeneous, spacing" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations vbox = Gtk.VBox(False, 8) gtk_spreadsheet_sgskip.py:39: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "label" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations label = Gtk.Label('Double click a row to plot the data') gtk_spreadsheet_sgskip.py:51: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "model" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations self.treeview = Gtk.TreeView(model) gtk_spreadsheet_sgskip.py:52: DeprecationWarning: Gtk.TreeView.set_rules_hint is deprecated self.treeview.set_rules_hint(True) ``` ``` pylab_with_gtk_sgskip.py:30: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "label" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations button = Gtk.Button('Click me') ``` Fix that, and some more.
83a4265 to
fe36a25
Compare
timhoffm
approved these changes
Dec 13, 2018
dstansby
approved these changes
Dec 14, 2018
|
I haven't been around for a bit so not sure what's happening with milestoneing, anyone (including @anntzer) feel free to milestone and merge. |
|
Let's just put this in 3.1, there's no hurry anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now they emit warnings:
Fix that, and some more.
PR Summary
PR Checklist