Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small bug fix in image_slices_viewer #13052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2018
Merged

Small bug fix in image_slices_viewer #13052

merged 1 commit into from
Dec 26, 2018

Conversation

pierrethibault
Copy link
Contributor

PR Summary

Tiny bug fix: the update method was accessing an out-of-scope axes instance that happened to have the same name.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@pierrethibault pierrethibault mentioned this pull request Dec 25, 2018
Closed
timhoffm
timhoffm approved these changes Dec 25, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@dstansby dstansby added this to the v3.0.3 milestone Dec 26, 2018
dstansby
dstansby approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@dstansby dstansby merged commit 6c3c28e into matplotlib:master Dec 26, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 26, 2018
@dstansby
Backport PR matplotlib#13052: Small bug fix in image_slices_viewer
34c0186
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 26, 2018
Merged
dstansby added a commit that referenced this pull request Dec 26, 2018
@dstansby
Merge pull request #13054 from meeseeksmachine/auto-backport-of-pr-13…
d3e8940 
…052-on-v3.0.x

Backport PR #13052 on branch v3.0.x (Small bug fix in image_slices_viewer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pierrethibault @timhoffm @dstansby