Inline some image-handling code for postscript. #13102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jan 4, 2019
| hexlines = b'\n'.join(self._hex_lines(bits)).decode('ascii') | ||
| h, w = im.shape[:2] | ||
| imagecmd = "false 3 colorimage" | ||
| data = im[::-1, :, :3] |
There was a problem hiding this comment.
maybe rgb_data instead of data to be a bit more telling?
There was a problem hiding this comment.
It's in draw_image; what else can it be?
If anything the interesting part is that it's upside down, not that it's rgb.
There was a problem hiding this comment.
Suggested change
| data = im[::-1, :, :3] | |
| data = im[::-1, :, :3] # vertically flipped rgb values |
might help when someone reads the code.
QuLogic
approved these changes
Jan 4, 2019
timhoffm
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Basically the not-failing part of #12871.
PR Checklist