Deprecate TextToPath.glyph_to_path. #13119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currx argument is unused, and realistic uses of glyph_to_path that may need currx (to generate the path for layouting multiple glyphs) would likely cache the path for performance anyways (as TextToPath does). If we deprecate currx, then we may as well deprecate glyph_to_path which becomes synonym to `font.get_path()`.
timhoffm
approved these changes
Jan 6, 2019
QuLogic
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currx argument is unused, and realistic uses of glyph_to_path that
may need currx (to generate the path for layouting multiple glyphs)
would likely cache the path for performance anyways (as TextToPath
does).
If we deprecate currx, then we may as well deprecate glyph_to_path which
becomes synonym to
font.get_path().Split out of #13108.
PR Summary
PR Checklist