-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Pin pytest<4.1 to unbreak CI tests #13122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Though should it just be !=4.1 ? |
Pytest > 4.1 will still have the same feature removed, so I think < 4.1 makes more sense until there's a new pytest-cov release. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
ouch, does not backport to either branch cleanly :( |
I hope that there will be a pytest-cov release soon since it's affecting all pojects using pytest-cov. This question is raised here pytest-dev/pytest-cov#253. Therefore, I would wait for an answer of the pytest-cov developers before pinning and later unpinning the other branches manually. |
@timhoffm fair enough. |
pytest-cov 2.6.1 has just been released. So no need to backport anymore. |
PR Summary
Temporary fix for #13121.
This can be undone once a new pytest-cov release is out.